Skip to content

Mark ownerEmail as required properties for workspace RP#6968

Merged
erich-wang merged 2 commits intoAzure:masterfrom
sherry1989:workspaceRP_fix
Aug 18, 2019
Merged

Mark ownerEmail as required properties for workspace RP#6968
erich-wang merged 2 commits intoAzure:masterfrom
sherry1989:workspaceRP_fix

Conversation

@sherry1989
Copy link
Copy Markdown
Contributor

@sherry1989 sherry1989 commented Aug 15, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Aug 15, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 8fbe830, Iteration 5)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
Pending Go: test-repo-billy/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: test-repo-billy/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: test-repo-billy/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci azuresdkci requested a review from erich-wang August 15, 2019 08:38
@AutorestCI AutorestCI mentioned this pull request Aug 15, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5552

@openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Aug 15, 2019
Merged
@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Aug 15, 2019

Can one of the admins verify this patch?

@anthony-c-martin anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 15, 2019
@ifeoluwaokunoren ifeoluwaokunoren mentioned this pull request Aug 15, 2019
Closed
@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
@erich-wang erich-wang merged commit 79c2711 into Azure:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erich-wang erich-wang erich-wang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sherry1989 @AutorestCI @azuresdkci @erich-wang @anthony-c-martin